HIVE-28362: Fail to materialize a CTE with VOID#5335
Closed
okumin wants to merge 1 commit intoapache:masterfrom
Closed
HIVE-28362: Fail to materialize a CTE with VOID#5335okumin wants to merge 1 commit intoapache:masterfrom
okumin wants to merge 1 commit intoapache:masterfrom
Conversation
|
Contributor
Author
|
Based on the discussion in JIRA, it is not a good idea to accept VOID because some data formats like Parquet or ORC don't support it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Allow materialized CTEs to hold NULL literals.
https://issues.apache.org/jira/browse/HIVE-28362
Why are the changes needed?
Materialized CTEs should keep the original semantics of the CTEs. Regular CTEs allow a VOID type, then materialized CTEs also allow it.
Does this PR introduce any user-facing change?
No
Is the change a dependency upgrade?
No
How was this patch tested?
Tested by the new qtest.